MAINT: enabling linkchecker at built time #162
Conversation
bsipocz
added
the
html rendering / skip testing
myst.yml
Outdated
| # These link resolve in the browser but generates did not resolve and 403 for the build | ||
| - https://irsa.ipac.caltech.edu/cgi-bin/Gator/nph-scan?projshort=SPITZER | ||
| - https://academic.oup.com/mnras/article/505/2/2954/6284767 |
There was a problem hiding this comment.
I see that the second one has a "verifying you're human" step. I wonder if the doi.org link would work better? https://doi.org/10.1093/mnras/stab1502
Any idea why the irsa one won't resolve in the build?
There was a problem hiding this comment.
not sure, about the irsa one, I even tried to remove the mission selection and even the Gator link didn't resolve.
There was a problem hiding this comment.
Looks like just a missing carriage return in the response. I brought it up with the backend team in case it's easy for them to fix. But I think it's fine to ignore it here for now and not hold up this PR waiting for it.
There was a problem hiding this comment.
sound good, thanks! I totally agree that this can go in as is; I'm just waiting for a passing build.
tutorials/parquet-catalog-demos/neowise-source-table-lightcurves.md
Outdated
Show resolved
Hide resolved
tutorials/parquet-catalog-demos/neowise-source-table-strategies.md
Outdated
Show resolved
Hide resolved
|
CI failure is unrelated, we're timing out on SPHEREx |
bsipocz
force-pushed
the
MAINT_using_strict
branch
from
0be5784 to
1a51ac1
Compare
|
There were significant server-side issues with SPHEREx archive yesterday but I reported to the backend team and they did some work on it. They told me that things look back to normal this morning so I re-ran this testing. On the first try it ran into the obscure error #161 but the other two spherex notebooks passed. On the second try everything passed. I'll let you merge this @bsipocz in case there was anything else you wanted to look at first. |
I think we should have this in and add any additions as follow-ups (There are other rules we can make more strict but for now getting the links should be a good improvement. And a couple of other parts I run into issues that still need to be properly reported upstream). |
| # Status check is a workaround until https://github.com/jupyter-book/mystmd/issues/2113 is fixed | ||
| buildhtml: bash -c "jupyter-book build --execute --html 2>&1 | tee /tmp/mystbuild.log" | ||
| buildhtml: bash -c "if grep -q 'Traceback .most recent call last.' /tmp/mystbuild.log; then exit 1; fi" | ||
| buildhtml: bash -c "echo 'Notebooks ignored (not tested/executed) in this job:\n'; cat ignore_execute" | ||
| # Using srtict so we fail with trackbacks and debug mode to have a richer log | ||
| buildhtml: bash -c "npx myst build --execute --html --strict -d" |
There was a problem hiding this comment.
The publish job failed after this merged. https://github.com/Caltech-IPAC/irsa-tutorials/actions/runs/18979533957/job/54208233775. It's complaining that it can't find the myst executable when it tries to run line 78. Maybe it's not being installed?
2 participants
This would do linkchecking amongst other thing to ensure all is as expected.
The PR includes some fixes and workarounds to the currently broken links and DOIs